Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open .BIN file because of toLower() #977

Open
Georacer opened this issue May 23, 2024 · 3 comments
Open

Cannot open .BIN file because of toLower() #977

Georacer opened this issue May 23, 2024 · 3 comments

Comments

@Georacer
Copy link

Problem description

Would it be possible to remove the use of toLower here?
https://github.com/facontidavide/PlotJuggler/blob/main/plotjuggler_app/mainwindow.cpp#L1460

It prevents our plugin from readings logs ending with .BIN. Instead, they need to be renamed to end with .bin.

Answer these questions (or I will ignore your issue)

  1. Describe your platform / Operative System and the version of PlotJuggler you are using.
    Ubuntu 22.04; PlotJuggler 3.9.1
  2. Compile and try the latest version in the main branch and check if the problem persists.
    Didn't do it, but I checked main and the line of code is still there.
  3. Check if the problem can be reproduced using the dummy data created by the command line argument "-t" or one of the files in the folder "datasamples".
    This check is not applicable to our custom .BIN file.
  4. If it can't be reproduced with the dummy data, please share the CSV file or the rosbag that can be used to reproduce the problem.
    Any Ardupilot dataflash log will do, but you'll need the plugin to open them.
    If you still need to try it, let me know.
@zdavkeos
Copy link
Contributor

When we had a similar plugin problem, we just added the lower case extension name to the plugin's list of supported extensions. See the csv loader for an example:

@Georacer
Copy link
Author

Georacer commented Jul 1, 2024

Hello @zdavkeos,

Unfortunately, this is not working for the reasons I explained above.
I tried it, for good measure, though.

As an example, a file called test_file.CSV cannot be opened by PlotJuggler, for the same reasons.

@muramura
Copy link

THIS PR:
#1003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants