From ef6334cef0ac6ff908784cf4cd05143bfe4c82ad Mon Sep 17 00:00:00 2001 From: Shinigami Date: Sun, 17 Sep 2023 13:16:09 +0200 Subject: [PATCH] ci: use node 20 (#2398) --- .github/workflows/ci.yml | 26 ++++++++++++++------------ .github/workflows/pr.yml | 6 +++--- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f209dabde50..9662d248cb3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,7 +72,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node_version: [18] + node_version: [20] fail-fast: false env: LANG: zh_SG.UTF-8 @@ -117,9 +117,11 @@ jobs: e2e-test: runs-on: ubuntu-latest - container: cypress/browsers:node18.12.0-chrome107 + container: + image: cypress/browsers:node-20.6.1-chrome-116.0.5845.187-1-ff-117.0-edge-116.0.1938.76-1 + options: --user 1001 timeout-minutes: 10 - name: 'E2E Doc Test: node-18, ubuntu-latest' + name: 'E2E Doc Test: node-20, ubuntu-latest' steps: - name: Checkout uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 @@ -140,7 +142,7 @@ jobs: lint: runs-on: ubuntu-latest timeout-minutes: 10 - name: 'Lint: node-18, ubuntu-latest' + name: 'Lint: node-20, ubuntu-latest' steps: - name: Checkout uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 @@ -150,10 +152,10 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@d882d12c64e032187b2edb46d3a0d003b7a43598 # v2.4.0 - - name: Set node version to 18 + - name: Set node version to 20 uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 18 + node-version: 20 cache: 'pnpm' - name: Install deps @@ -170,7 +172,7 @@ jobs: ts-check: runs-on: ubuntu-latest timeout-minutes: 10 - name: 'TS-Check: node-18, ubuntu-latest' + name: 'TS-Check: node-20, ubuntu-latest' steps: - name: Checkout uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 @@ -180,10 +182,10 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@d882d12c64e032187b2edb46d3a0d003b7a43598 # v2.4.0 - - name: Set node version to 18 + - name: Set node version to 20 uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 18 + node-version: 20 cache: 'pnpm' - name: Install deps @@ -197,7 +199,7 @@ jobs: codecov: runs-on: ubuntu-latest timeout-minutes: 10 - name: 'Codecov: node-18, ubuntu-latest' + name: 'Codecov: node-20, ubuntu-latest' steps: - name: Checkout uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 @@ -207,10 +209,10 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@d882d12c64e032187b2edb46d3a0d003b7a43598 # v2.4.0 - - name: Set node version to 18 + - name: Set node version to 20 uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 18 + node-version: 20 cache: 'pnpm' - name: Install deps diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 2653eab0df0..82f7892df3f 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -10,7 +10,7 @@ jobs: check-code-generation: runs-on: ubuntu-latest timeout-minutes: 10 - name: 'Check Code Generation: node-18, ubuntu-latest' + name: 'Check Code Generation: node-20, ubuntu-latest' permissions: pull-requests: write steps: @@ -22,10 +22,10 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@d882d12c64e032187b2edb46d3a0d003b7a43598 # v2.4.0 - - name: Set node version to 18 + - name: Set node version to 20 uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 18 + node-version: 20 cache: 'pnpm' - name: Install deps