Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rodent breed on animal 'en' locale #1136

Merged
merged 6 commits into from
Jul 30, 2022
Merged

feat: add rodent breed on animal 'en' locale #1136

merged 6 commits into from
Jul 30, 2022

Conversation

LordFitoi
Copy link
Contributor

  • Added rodent breed on en locale.
  • Added a list of over 150 rodent breeds.
  • Added tests for rodent method in animal.spec.ts.snap

@LordFitoi LordFitoi requested a review from a team as a code owner July 8, 2022 12:24
@Shinigami92 Shinigami92 added c: feature Request for new feature p: 1-normal Nothing urgent labels Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #1136 (1e419de) into main (fc48155) will decrease coverage by 0.00%.
The diff coverage is 99.50%.

@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2152     2153       +1     
  Lines      236291   236493     +202     
  Branches      975      976       +1     
==========================================
+ Hits       235404   235605     +201     
- Misses        866      867       +1     
  Partials       21       21
Impacted Files Coverage Δ
src/definitions/animal.ts 0.00% <0.00%> (ø)
src/locales/en/animal/index.ts 100.00% <100.00%> (ø)
src/locales/en/animal/rodent.ts 100.00% <100.00%> (ø)
src/modules/animal/index.ts 100.00% <100.00%> (ø)

Shinigami92
Shinigami92 previously approved these changes Jul 8, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from a team July 8, 2022 12:33
pkuczynski
pkuczynski previously approved these changes Jul 8, 2022
View reviewed changes
@ST-DDT ST-DDT modified the milestone: v7 - Current Major Jul 8, 2022
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug labels Jul 8, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jul 8, 2022

Preview ✅

grafik

ST-DDT
ST-DDT previously approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort the rodent file alphabetically.

@LordFitoi
fix: breeds sorted alphabetically
d5c1398 
Genus denotation was removed from all breed names.
Breeds were sorted alphabetically.
@LordFitoi LordFitoi dismissed stale reviews from ST-DDT, pkuczynski, and Shinigami92 via d5c1398 July 9, 2022 13:37
@LordFitoi
Copy link
Contributor Author

LordFitoi commented Jul 9, 2022 •
edited
Loading

Sorted alphabetically 👍 @ST-DDT

@LordFitoi LordFitoi requested review from ST-DDT and pkuczynski July 9, 2022 14:11
ST-DDT
ST-DDT previously approved these changes Jul 9, 2022
View reviewed changes
ejcheng
ejcheng previously approved these changes Jul 10, 2022
View reviewed changes
@ST-DDT ST-DDT requested review from a team July 11, 2022 08:02
@ST-DDT
Copy link
Member

ST-DDT commented Jul 22, 2022

Could you please update your branch with the latest changes from the main branch?

@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jul 22, 2022
@xDivisionByZerox xDivisionByZerox added the m: animal Something is referring to the animal module label Jul 28, 2022
@LordFitoi
Copy link
Contributor Author

Sure

@LordFitoi LordFitoi dismissed stale reviews from ejcheng and ST-DDT via 3c22522 July 29, 2022 00:16
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Jul 29, 2022
@ST-DDT ST-DDT requested a review from a team July 29, 2022 08:58
@ST-DDT ST-DDT enabled auto-merge (squash) July 29, 2022 08:59
@ST-DDT ST-DDT merged commit a65f1a2 into faker-js:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@Minozzzi Minozzzi Minozzzi approved these changes

@ejcheng ejcheng ejcheng left review comments

@pkuczynski pkuczynski Awaiting requested review from pkuczynski

Assignees

@LordFitoi LordFitoi

Labels
c: feature Request for new feature m: animal Something is referring to the animal module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
7 participants
@LordFitoi @ST-DDT @pkuczynski @Shinigami92 @Minozzzi @ejcheng @xDivisionByZerox