Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add male first names starting with Z to id_ID #1424

Merged
merged 2 commits into from
Oct 10, 2022
Merged

feat(locale): add male first names starting with Z to id_ID #1424

merged 2 commits into from
Oct 10, 2022

Conversation

fzn0x
Copy link
Contributor

@fzn0x fzn0x commented Oct 10, 2022

I saw that we are missing starts with Z for male first name, but actually there is

It is Zaki, Zakir, and Zulfikar, it is commonly used for millenials muslims male first name.

There's more, but I probably would added these 3 because it is the most common used.

@fzn0x fzn0x requested a review from a team as a code owner October 10, 2022 11:19
@fzn0x fzn0x marked this pull request as draft October 10, 2022 11:19
@fzn0x fzn0x closed this Oct 10, 2022
@fzn0x fzn0x reopened this Oct 10, 2022
@fzn0x fzn0x marked this pull request as ready for review October 10, 2022 11:20
@fzn0x fzn0x changed the title feat(id_ID): Adding starts with Z people name feat(id_ID): Adding starts with Z male first name Oct 10, 2022
@xDivisionByZerox xDivisionByZerox added c: locale Permutes locale definitions m: person Something is referring to the person module labels Oct 10, 2022
@fzn0x
Copy link
Contributor Author

fzn0x commented Oct 10, 2022

accidently click close PR instead of ready for review 😄

@fzn0x
Copy link
Contributor Author

fzn0x commented Oct 10, 2022

Test failing on

[2022-10-10T11:24:38.503Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Looks like it's unrelated to this PR.

@xDivisionByZerox xDivisionByZerox requested a review from a team October 10, 2022 11:25
@xDivisionByZerox
Copy link
Member

Looks like it's unrelated to this PR.

Yes, you are right. I'll try to rerun the test. Propably a network connection error or something like that.

@xDivisionByZerox
Copy link
Member

Hm, that wasn't the issue. I remember that we restricted access to each job individually. Might be an issue in the workflow config (but unrelated to this PR).

@Shinigami92 or @ST-DDT might you to take a look into this?

@xDivisionByZerox
Copy link
Member

@fzn0x could you please add a minimal description to the PR? Would be highly appreciated.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 10, 2022
@fzn0x
Copy link
Contributor Author

fzn0x commented Oct 10, 2022

@fzn0x could you please add a minimal description to the PR? Would be highly appreciated.

Added :) !

@fzn0x
Copy link
Contributor Author

fzn0x commented Oct 10, 2022

All the tests is passed. Thanks for the fast response!

Little tip:
Screenshot 2022-10-10 185409

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1424 (d1e95d9) into main (0d6afb1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.01%     
==========================================
  Files        2166     2166              
  Lines      237442   237445       +3     
  Branches     1042     1040       -2     
==========================================
- Hits       236545   236538       -7     
- Misses        876      886      +10     
  Partials       21       21              
Impacted Files Coverage Δ
src/locales/id_ID/name/male_first_name.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 81.74% <0.00%> (-2.65%) ⬇️

@ST-DDT ST-DDT added this to the v7 - Current Major milestone Oct 10, 2022
@Shinigami92 Shinigami92 changed the title feat(id_ID): Adding starts with Z male first name feat(locale): Adding starts with Z male first name to id_ID Oct 10, 2022
@ST-DDT ST-DDT changed the title feat(locale): Adding starts with Z male first name to id_ID feat(locale): add male first name starting with Z to id_ID Oct 10, 2022
@ST-DDT ST-DDT changed the title feat(locale): add male first name starting with Z to id_ID feat(locale): add male first names starting with Z to id_ID Oct 10, 2022
@import-brain
Copy link
Member

All the tests is passed. Thanks for the fast response!

Little tip: Screenshot 2022-10-10 185409

Thank you!

@ST-DDT ST-DDT merged commit f921c14 into faker-js:main Oct 10, 2022
@fzn0x fzn0x deleted the patch-2 branch October 10, 2022 23:08
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants