Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on strictNullChecks in tsconfig #1834

Closed
ST-DDT opened this issue Feb 13, 2023 · 5 comments · Fixed by #2435
Closed

Turn on strictNullChecks in tsconfig #1834

ST-DDT opened this issue Feb 13, 2023 · 5 comments · Fixed by #2435
Assignees
@ST-DDT
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 13, 2023 •
edited
Loading

#651 partially activated strict mode, this flag was omitted at that time and should probably be turned on.

faker/tsconfig.json

Line 11 in c46c539

// "strictNullChecks": true,

Related issues:
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Feb 13, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Feb 13, 2023
This was referenced Feb 13, 2023
Merged
Closed
Closed
Closed
Closed
@Shinigami92
Copy link
Member

This raised around 200 errors

Mostly coming from this.faker.definitions.xy might be undefined

So theoretically this is related to

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 14, 2023

I consider this blocked by #893

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Feb 14, 2023
@ST-DDT ST-DDT mentioned this issue Apr 30, 2023
Merged
@xDivisionByZerox xDivisionByZerox removed the s: on hold Blocked by something or frozen to avoid conflicts label May 2, 2023
@xDivisionByZerox
Copy link
Member

@Shinigami92 are you working on this? Is this blocked by #2102?

@Shinigami92
Copy link
Member

@Shinigami92 are you working on this? Is this blocked by #2102?

Yes and yes 👍

@Shinigami92 Shinigami92 self-assigned this May 2, 2023
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap May 2, 2023
@xDivisionByZerox xDivisionByZerox added the s: on hold Blocked by something or frozen to avoid conflicts label May 2, 2023
@Shinigami92 Shinigami92 mentioned this issue May 6, 2023
Merged
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 5, 2023
@ST-DDT ST-DDT mentioned this issue Oct 5, 2023
Merged
@ST-DDT ST-DDT assigned ST-DDT and unassigned Shinigami92 Oct 5, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 5, 2023

I started a PR to fix this: #2435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: In Progress
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

infra: enable strictNullChecks in tsconfig faker-js/faker
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox