Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff for v8.0.1 #2151

Closed
6 tasks done
Shinigami92 opened this issue May 11, 2023 · 10 comments
Closed
6 tasks done

Stuff for v8.0.1 #2151

Shinigami92 opened this issue May 11, 2023 · 10 comments
Labels
p: 2-high Fix main branch

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented May 11, 2023

  • Update playground
  • Switch Netlify
  • Update StackBlitz demo
  • Docs need to reference fakerjs.dev instead of next.fakerjs.dev
  • Improve v8.0.0 release with some notes about breaking changes and link to upgrading guide
  • Clean README.md (in v8 branch)
@Shinigami92 Shinigami92 added the p: 2-high Fix main branch label May 11, 2023
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap May 11, 2023
@Shinigami92 Shinigami92 pinned this issue May 11, 2023
@matthewmayer
Copy link
Contributor

Maybe also add a new announcement in https://fakerjs.dev/about/announcements.html ? Seems worthy of one.

@Shinigami92
Copy link
Member Author

Maybe also add a new announcement in fakerjs.dev/about/announcements.html ? Seems worthy of one.

As well as social media post(s).

So yes, "but" this is not part for v8.0.1 or like "we need to do that asap"
Quite the reverse, we want to do the announcement stuff and set v8 as stable only in a week or later.

@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap May 12, 2023
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap May 15, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Faker Roadmap May 15, 2023
@Shinigami92 Shinigami92 unpinned this issue May 15, 2023
@HonzaMac
Copy link
Contributor

Can we also adjust Changelog.md?

We received update via Renovate Bot, but changes show only 8.0.0 and 8.0.1, but nothing from previous alpha/beta release notes.

@Shinigami92
Copy link
Member Author

Can we also adjust Changelog.md?

We received update via Renovate Bot, but changes show only 8.0.0 and 8.0.1, but nothing from previous alpha/beta release notes.

This is unfortunately 🤔 the Changelog.md is auto-generated

Please read https://github.com/faker-js/faker/releases/tag/v8.0.1 and https://github.com/faker-js/faker/releases/tag/v8.0.0

@HonzaMac
Copy link
Contributor

Can be the autogeneration fixed? It is confusing even when I read changelog file by self.

@matthewmayer
Copy link
Contributor

Is there anything to stop us manually editing the Changelog.md (to merge all the alpha/beta/final release of 8.0.0 into one?)

@Shinigami92
Copy link
Member Author

Is there anything to stop us manually editing the Changelog.md (to merge all the alpha/beta/final release of 8.0.0 into one?)

It would need to be done within the PR when crafting a release, but we decided that we auto-generate the changelog but manually write the upper part of a release note if necessary
Also releases on GitHub can be edited and are not fixed to a released tag / npm dist folder

If renovate only parses Changelog.md files, then they should consider also at least to link to the GitHub release page

@matthewmayer
Copy link
Contributor

Do you have an example of what renovate shows for a project with a dependency of faker 7.6.0 now that 8.0.1 is available?

@HonzaMac
Copy link
Contributor

image

@Shinigami92
Copy link
Member Author

Yeah... please open an issue at Renovate to tell them they should also link to GitHub Release Notes

In the meanwhile we will just try to to release so many alphas and betas maybe 🤔 ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 2-high Fix main branch
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants