Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine country_code definitions in all locales to ensure only relevant data is included #2305

Open
ejcheng opened this issue Aug 10, 2023 · 1 comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@ejcheng
Copy link
Member

ejcheng commented Aug 10, 2023

Our country_code definitions are inconsistent at this time. We should consider going through each locale's country_code definitions and ensure that the only entries in that locale are countries that are relevant (proximity, etc) to the selected locale. Also, we would need to refine our JSDocs to explain this.

This issue is an expanded form of #1861.

@ejcheng ejcheng added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: locale Permutes locale definitions labels Aug 10, 2023
@ST-DDT ST-DDT added the m: location Something is referring to the location module label Aug 10, 2023
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Aug 10, 2023

Team decision:

We generally want this.
More generic locales (en, de) should contain a wider range of relevant contry codes. The more specific a locale gets, the more specific the country codes should be as well.

All locale groups changes should be provided in a separate PR to allow for more fine grained research on those locales.

@ejcheng ejcheng added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants