Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: param can be optional #381

Merged
merged 1 commit into from
Feb 1, 2022
Merged

fix: param can be optional #381

merged 1 commit into from
Feb 1, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 31, 2022 •
edited
Loading

Discovered by #372

@Shinigami92 Shinigami92 added c: bug Something isn't working p: 2-high Fix main branch labels Jan 31, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 31, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 31, 2022 19:39
@Shinigami92 Shinigami92 requested a review from a team January 31, 2022 20:15
prisis
prisis reviewed Jan 31, 2022
View reviewed changes
src/name.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 merged commit f8a95a1 into main Feb 1, 2022
@Shinigami92 Shinigami92 deleted the name-gender-param-optional branch February 1, 2022 07:51
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @bmenant
fix: param can be optional (faker-js#381)
f3189d0
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
fix: param can be optional (faker-js#381)
8a0437d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

@ejcheng ejcheng ejcheng approved these changes

@griest024 griest024 Awaiting requested review from griest024

Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working p: 2-high Fix main branch
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @ST-DDT @prisis @ejcheng