Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Support Node18 when it drops #42

Closed
damienwebdev opened this issue Jan 9, 2022 · 0 comments · Fixed by #847
Closed

FEAT: Support Node18 when it drops #42

damienwebdev opened this issue Jan 9, 2022 · 0 comments · Fixed by #847
Assignees
@Shinigami92
Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v7.0 - Structural...

Comments

@damienwebdev
Copy link
Member

https://nodejs.org/en/about/releases/

Node 18 is slated to release on 2022-04-19, we need to update the ci pipeline to this on that day.
@Shinigami92 Shinigami92 added the c: feature Request for new feature label Jan 9, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 23, 2022
@Shinigami92 Shinigami92 linked a pull request Apr 21, 2022 that will close this issue
build: add node v18 support #847
Merged
@Shinigami92 Shinigami92 self-assigned this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7.0 - Structural Breaking Changes
Development

Successfully merging a pull request may close this issue.

build: add node v18 support faker-js/faker
2 participants
@Shinigami92 @damienwebdev