Check use of the #{pattern}s in the locales

[ST-DDT]

Describe the bug

A lot of locale files such as https://github.com/faker-js/faker/blob/main/src/locales/en/address/city.ts contain a #{pattern}

These files aren't used anywhere and faker does not have a method to use/resolve them with.

Did faker.fake() support this syntax at some point or have they been forgotten during a refactor related to faker.fake()?

I'm not sure what to do with them.

Reproduction

faker/src/locales/en/address/city.ts

Lines 1 to 6 in 2532eb9

	export default [
	'#{city_prefix} #{Name.first_name}#{city_suffix}',
	'#{city_prefix} #{Name.first_name}',
	'#{Name.first_name}#{city_suffix}',
	'#{Name.last_name}#{city_suffix}',
	];

Additional Info

There are almost 200 locale files that contain these.

[Shinigami92]

Never recognized this #{ before 🤔

[ST-DDT]

I traced it back to this commit:

faker/lib/locales/en.js

Lines 1027 to 1032 in 0048b9f

	"city": [
	"#{city_prefix} #{Name.first_name}#{city_suffix}",
	"#{city_prefix} #{Name.first_name}",
	"#{Name.first_name}#{city_suffix}",
	"#{Name.last_name}#{city_suffix}"
	],

[api] First pass at adding localization data definitions. #116

(14 Sep 2014) which was included in v2.0.0

I searched a few files and commits, but didn't find any method ever dealing with this syntax.

[cxcorp]

I'm not sure if this is related, but the en_GH locale seems to produce a lot of strings with those in them:

faker.locale = 'en_GH';
faker.internet.exampleEmail();
// 'male_first_name22@example.com'
faker.internet.userName()
// '#{female_first_name}.Akowua'

[ST-DDT]

https://github.com/faker-js/faker/blob/main/src/locales/en_GH/name/first_name.ts
https://github.com/faker-js/faker/blob/main/src/locales/en/name/first_name.ts

In this case its more like a bug. The file contains bad data.
You could create a PR that imports both male and female, sorts and exports them instead.
Otherwise it might take a while before we can fix these.

[ST-DDT]

Will hopefully be fixed by #927