Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation message before refactoring - arrayElement() #902

Closed
rota-rossi opened this issue May 2, 2022 · 3 comments · Fixed by #903
Closed

Deprecation message before refactoring - arrayElement() #902

rota-rossi opened this issue May 2, 2022 · 3 comments · Fixed by #903
Assignees
Labels
c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug

Comments

@rota-rossi
Copy link

Describe the bug

On release 6.3.0, it was added a warning that faker.random.arrayElement is deprecated - but other functions like faker.random.alphaNumeric are still referencing the obsolete one.

Reproduction

just call fake.random.alphaNumeric():

$ node                                                                                                                                                              ─╯
Welcome to Node.js v16.14.0.
Type ".help" for more information.
> const {faker} = require('@faker-js/faker');
undefined
> faker.random.alphaNumeric()
[@faker-js/faker]: faker.random.arrayElement() is deprecated since v6.3.0 and will be removed in v7.0.0. Please use faker.helpers.arrayElement() instead.
'l'

Additional Info

should be considered holding adding deprecation notices until all internal functions are refactored to remove the dependency from the deprecated method.

@rota-rossi rota-rossi added the s: pending triage Pending Triage label May 2, 2022
@ST-DDT ST-DDT added c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug and removed s: pending triage Pending Triage labels May 2, 2022
@ST-DDT ST-DDT moved this to Awaiting Review in Faker Roadmap May 2, 2022
@ST-DDT ST-DDT added this to the v6.3 - Next Minor milestone May 2, 2022
@ST-DDT ST-DDT moved this from Awaiting Review to Todo in Faker Roadmap May 2, 2022
@Shinigami92
Copy link
Member

Thx for the report
We used search and replace, but missed the calls inside the random module itself

@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap May 2, 2022
@Shinigami92 Shinigami92 self-assigned this May 2, 2022
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap May 2, 2022
@rota-rossi
Copy link
Author

@Shinigami92, not a problem - sorry if I sounded aggressive in my report (I was re-reading it and it sounded to me like I was).

and thanks a lot for your work on keeping this library up-to-date!

@Shinigami92
Copy link
Member

Shinigami92 commented May 2, 2022

@Shinigami92, not a problem - sorry if I sounded aggressive in my report (I was re-reading it and it sounded to me like I was).

and thanks a lot for your work on keeping this library up-to-date!

To be fair, I didn't really read your issue 🤣 I just saw the problem and fixed it ❤️
You know, the maintainers of faker are also humans 🙂 🤷

Repository owner moved this from Awaiting Review to Done in Faker Roadmap May 2, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants