Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove duplicate fixed-seeded-tests #1653

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 11, 2022

It looks like we forgot to remove some old fixed-seeded-tests when we added the seededTestFactory.
This PR removes the obsolete tests.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test s: accepted Accepted feature / Confirmed bug m: system Something is referring to the system module labels Dec 11, 2022
@ST-DDT ST-DDT requested review from a team December 11, 2022 01:17
@ST-DDT ST-DDT self-assigned this Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #1653 (f98a635) into next (cf764b9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1653   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2221     2221           
  Lines      240108   240108           
  Branches     1049     1049           
=======================================
  Hits       239236   239236           
  Misses        851      851           
  Partials       21       21           

@ST-DDT ST-DDT requested review from import-brain, xDivisionByZerox and a team December 12, 2022 18:33
@ST-DDT ST-DDT enabled auto-merge (squash) December 13, 2022 15:34
@ST-DDT ST-DDT merged commit db6b555 into next Dec 13, 2022
@ST-DDT ST-DDT deleted the test/system/remove-duplicate-fixed-seeded-tests branch December 13, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: system Something is referring to the system module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants