Add Bank.iban_country_code. #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method returns a random ISO 8601 code for a country that uses the IBAN system. Updates `Bank.iban` to use a random country code when the `country_code` param is passed as `nil`.
I think it's ISO 3166, not ISO 8601, but overall it looks good 👍 |
|
|
|
Thanks! |
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2244
Description:
As described in the ticket, there is currently no way to randomly get a valid IBAN across countries.
The new method returns a random ISO 3166 code for a country that uses the IBAN system.
Updates
Bank.ibanto use a random country code when thecountry_codeparam is passed asnil.