Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RuboCop to 1.10.0 #2272

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Bump RuboCop to 1.10.0 #2272

merged 1 commit into from
Feb 23, 2021

Commits on Feb 23, 2021

  1. Bump RuboCop to 1.10.0

    Closes faker-ruby#2267.
    
    This PR bumps RuboCop to 1.10.0 and disables `Naming/VariableNumber` as
    there is no strong reason to change the names below.
    
    ```console
    % bundle exec rubocop --only Naming/VariableNumber
    (snip)
    
    Offenses:
    
    lib/faker/default/invoice.rb:107:11: C: Naming/VariableNumber: Use
    normalcase for method name numbers.
    def method_731(base)
        ^^^^^^^^^^
    lib/faker/default/source.rb:68:11: C: Naming/VariableNumber: Use
    normalcase for method name numbers.
    def print_1_to_10(legacy_lang = NOT_GIVEN, lang: :ruby)
        ^^^^^^^^^^^^^
    test/faker/default/test_faker_id_number.rb:157:7: C:
    Naming/VariableNumber: Use normalcase for method name numbers.
    def test_chilean_verification_code_0
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/faker/default/test_faker_internet.rb:148:7: C:
    Naming/VariableNumber: Use normalcase for method name numbers.
    def test_password_with_min_length_eq_1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/faker/default/test_faker_national_health_service.rb:14:7: C:
    Naming/VariableNumber: Use normalcase for method name numbers.
    def test_nhs_check_digit_equals_10
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/faker/default/test_faker_national_health_service.rb:24:7: C:
    Naming/VariableNumber: Use normalcase for method name numbers.
    def test_nhs_check_digit_11
        ^^^^^^^^^^^^^^^^^^^^^^^
    test/test_bg_locale.rb:47:7: C: Naming/VariableNumber: Use normalcase
    for method name numbers.
    def test_bg_cell_number_starts_wiht_08
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/test_ca_cat_locale.rb:29:7: C: Naming/VariableNumber: Use
    normalcase for method name numbers.
    def test_ca_cat_phone_numbers_start_with_9
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/test_ca_cat_locale.rb:34:7: C: Naming/VariableNumber: Use
    normalcase for method name numbers.
    def test_ca_cat_cell_numbers_start_with_6
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/test_en_au_locale.rb:32:7: C: Naming/VariableNumber: Use normalcase
    for method name numbers.
    def test_aussie_mobiles_start_with_04
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/test_en_ng_locale.rb:36:7: C: Naming/VariableNumber: Use normalcase
    for method name numbers.
    def test_en_ng_phonenumber_starts_with_0
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    499 files inspected, 11 offenses detected
    ```
    koic committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    9a8a555 View commit details
    Browse the repository at this point in the history