New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reafactor ParserTests.cs #12

Open

craigsmitham opened this issue Nov 3, 2015 · 0 comments

Labels

Documentation Testing

Member

craigsmitham commented Nov 3, 2015

Right now https://github.com/falcordotnet/falcor.net/blob/master/src/Falcor.Tests/Server/Routing/ParserTests.cs is a little all over the place. Here are some suggestions for improvement:

Refactor parsing tests into separate classes that test against IRouteParser and IPathParser interfaces that clearly show parser behavior and can be used to test alternate (perhaps more performant) implementations
Create a separate test class for testing route matching behavior separate from parsing to more clearly illustrate and communicate intended route matching behavior

The text was updated successfully, but these errors were encountered:

craigsmitham added Documentation Testing labels

craigsmitham mentioned this issue

Does falcor.net support {keys} Pattern? #10

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment