Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Loki endpoint and json format #351

Closed
sboschman opened this issue Aug 3, 2022 · 3 comments
Closed

Update Loki endpoint and json format #351

sboschman opened this issue Aug 3, 2022 · 3 comments
Labels
kind/feature New feature or request
Milestone

Comments

@sboschman
Copy link

Motivation

Currently falcosidekick uses the deprecated Loki /api/prom/push endpoint (https://grafana.com/docs/loki/v2.6.x/api/#post-apiprompush). Might be a good idea to switch to the new Loki /loki/api/vi/push endpoint (https://grafana.com/docs/loki/v2.6.x/api/#push-log-entries-to-loki), including the new json format, before the old endpoint is dropped.

Feature

Switch Loki endpoint and json message format to the /loki/api/v1/push endpoint. I believe this endpoint has been available since Loki v1.0.0. Anyways, the oldest documentation on the site is for v1.6.x (https://grafana.com/docs/loki/v1.6.x/api/#post-lokiapiv1push), which has the endpoint. Loki v1.6.0 was released on 13 Aug 2020, so imho support for the old endpoint can just be dropped.

Alternatives

Assume Loki never drops this deprecated endpoint 😨

Additional context

@sboschman sboschman added the kind/feature New feature or request label Aug 3, 2022
@Issif
Copy link
Member

Issif commented Aug 3, 2022

Hi,

The PR #309 introduced the possibility to set the URI for Loki endpoint, I agree it's time to use /loki/api/v1/push as default and the JSON format (much easier to debug). For avoiding to break things for users with old Loki servers, I'll add a option to choose the event format, just in case.

@Issif Issif added this to the 2.27.0 milestone Aug 3, 2022
@Issif
Copy link
Member

Issif commented Aug 23, 2022

I finally decided to deprecate the old format for the new one, as it's there for a while. It seems to be ok in my last tests:
image

@Issif
Copy link
Member

Issif commented Aug 24, 2022

It will be released with next version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants