Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcosidekick overwrites cloudevent spec attribute #580

Closed
Typhlos opened this issue Aug 7, 2023 · 1 comment
Closed

Falcosidekick overwrites cloudevent spec attribute #580

Typhlos opened this issue Aug 7, 2023 · 1 comment
Labels
kind/bug Something isn't working
Milestone

Comments

@Typhlos
Copy link

Typhlos commented Aug 7, 2023

Describe the bug

When setting up falcosidekick to transfer falco events to a cloudevents broker such as knative, it throws the following error:

[ERROR] : CloudEvents - extension:source: bad key "source": CloudEvents spec attribute MUST NOT be overwritten by extension

This is due to this line of the cloudevents go-sdk. More precisely, it is due to the fact that falcosidekick uses source as an attribute when it should not according to the cloudevents spec.

How to reproduce it

Install falco with falcosidekick exporting events to a cloudevents broker such as knative. Follow for instance this blog post.

Expected behaviour

Falcosidekick should not use the source attribute.

Environment

  • Falco version:
{"default_driver_version":"5.0.1+driver","driver_api_version":"4.0.0","driver_schema_version":"2.0.0","engine_version":"17","falco_version":"0.35.1","libs_version":"0.11.3","plugin_api_version":"3.0.0"}
  • System info:
{
  "machine": "x86_64",
  "nodename": "falco-vvsjz",
  "release": "5.10.0-23-amd64",
  "sysname": "Linux",
  "version": "#1 SMP Debian 5.10.179-2 (2023-07-14)"
}
  • Cloud provider or hardware configuration:
    Bare metal
  • OS:
    Debian GNU/Linux 11 (bullseye)
  • Kernel:
Linux falco-vvsjz 5.10.0-23-amd64 #1 SMP Debian 5.10.179-2 (2023-07-14) x86_64 GNU/Linux
  • Installation method:
    Kubernetes
@Typhlos Typhlos added the kind/bug Something isn't working label Aug 7, 2023
@Issif Issif added this to the 2.29.0 milestone Aug 7, 2023
@Issif Issif moved this from To do to In progress in Falcosidekick 2.x Aug 7, 2023
@Typhlos
Copy link
Author

Typhlos commented Aug 8, 2023

Thank you for the quick fix !

@Typhlos Typhlos closed this as completed Aug 8, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Falcosidekick 2.x Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants