Add test for discord and refactor

outputs/discord.go

@@ -1,6 +1,7 @@
 package outputs
 
 import (
+	"fmt"
 	"strings"
 
 	"github.com/falcosecurity/falcosidekick/types"
@@ -62,26 +63,17 @@ func newDiscordPayload(falcopayload types.FalcoPayload, config *types.Configurat
 	for i, j := range falcopayload.OutputFields {
 		switch v := j.(type) {
 		case string:
-			embedField.Name = i
-			embedField.Inline = true
-			embedField.Value = "```" + v + "```"
+			embedField = discordEmbedFieldPayload{i, fmt.Sprintf("```%s```", v), true}
 		default:
 			continue
 		}
+
 		embedFields = append(embedFields, embedField)
 	}
-	embedField.Name = Rule
-	embedField.Value = falcopayload.Rule
-	embedField.Inline = true
-	embedFields = append(embedFields, embedField)
-	embedField.Name = Priority
-	embedField.Value = falcopayload.Priority
-	embedField.Inline = true
-	embedFields = append(embedFields, embedField)
-	embedField.Name = Time
-	embedField.Value = falcopayload.Time.String()
-	embedField.Inline = true
-	embedFields = append(embedFields, embedField)
+
+	embedFields = append(embedFields, discordEmbedFieldPayload{Rule, falcopayload.Rule, true})
+	embedFields = append(embedFields, discordEmbedFieldPayload{Priority, falcopayload.Priority, true})
+	embedFields = append(embedFields, discordEmbedFieldPayload{Time, falcopayload.Time.String(), true})
 
 	embed := discordEmbedPayload{
 		Title:       "",
@@ -91,12 +83,11 @@ func newDiscordPayload(falcopayload types.FalcoPayload, config *types.Configurat
 	}
 	embeds = append(embeds, embed)
 
-	ds := discordPayload{
+	return discordPayload{
 		Content:   "",
 		AvatarURL: iconURL,
 		Embeds:    embeds,
 	}
-	return ds
 }
 
 // DiscordPost posts events to discord

outputs/discord_test.go

@@ -0,0 +1,55 @@
+package outputs
+
+import (
+	"encoding/json"
+	"fmt"
+	"testing"
+
+	"github.com/falcosecurity/falcosidekick/types"
+	"github.com/stretchr/testify/require"
+)
+
+func TestNewDiscordPayload(t *testing.T) {
+	expectedOutput := discordPayload{
+		Content:   "",
+		AvatarURL: DefaultIconURL,
+		Embeds: []discordEmbedPayload{
+			{
+				Title:       "",
+				Description: "This is a test from falcosidekick",
+				Color:       "12370112", // light grey
+				Fields: []discordEmbedFieldPayload{
+					{
+						Name:   "proc.name",
+						Value:  fmt.Sprintf("```%s```", "falcosidekick"),
+						Inline: true,
+					},
+					{
+						Name:   "rule",
+						Value:  "Test rule",
+						Inline: true,
+					},
+					{
+						Name:   "priority",
+						Value:  "Debug",
+						Inline: true,
+					},
+					{
+						Name:   "time",
+						Value:  "2001-01-01 01:10:00 +0000 UTC",
+						Inline: true,
+					},
+				},
+			},
+		},
+	}
+
+	var f types.FalcoPayload
+	require.Nil(t, json.Unmarshal([]byte(falcoTestInput), &f))
+	config := &types.Configuration{
+		Discord: types.DiscordOutputConfig{},
+	}
+
+	output := newDiscordPayload(f, config)
+	require.Equal(t, output, expectedOutput)
+}

types/types.go

@@ -28,7 +28,7 @@ type Configuration struct {
 	Rocketchat    rocketchatOutputConfig
 	Teams         teamsOutputConfig
 	Datadog       datadogOutputConfig
-	Discord       discordOutputConfig
+	Discord       DiscordOutputConfig
 	Alertmanager  alertmanagerOutputConfig
 	Elasticsearch elasticsearchOutputConfig
 	Influxdb      influxdbOutputConfig
@@ -93,7 +93,7 @@ type datadogOutputConfig struct {
 	MinimumPriority string
 }
 
-type discordOutputConfig struct {
+type DiscordOutputConfig struct {
 	WebhookURL      string
 	MinimumPriority string
 	Icon            string