Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Coin from node #180

Closed
h4sh3d opened this issue Nov 23, 2021 · 1 comment · Fixed by #266
Closed

Adding Coin from node #180

h4sh3d opened this issue Nov 23, 2021 · 1 comment · Fixed by #266
Labels
enhancement New feature or request good first issue Good for newcomers node Node specific
Milestone
v0.5.0

Comments

@h4sh3d
Copy link
Member

h4sh3d commented Nov 23, 2021

merging Coin with the constructs used in core would also be appreciated

Originally posted by @zkao in farcaster-project/farcaster-node#230 (comment)
@h4sh3d h4sh3d added enhancement New feature or request good first issue Good for newcomers node Node specific labels Jun 17, 2022
@h4sh3d h4sh3d added this to the v0.5.0 milestone Jul 1, 2022
@h4sh3d
Copy link
Member Author

h4sh3d commented Jul 12, 2022

core::blockchain::Blockchain should become a replacement to current node::syncerd::opts::Coin. Blockchain must implement all traits currently used by Coin so it can be replaced in 0.5.0 update.

@h4sh3d h4sh3d mentioned this issue Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers node Node specific
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

feat: implement necessary traits to replace Coin with Blockchain in node h4sh3d/farcaster-core
1 participant
@h4sh3d