-
-
Notifications
You must be signed in to change notification settings - Fork 12
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reportabuse #21
Comments
|
Again, I'm a big fan so far of the project. I'm definitely gonna work on it for a little and try and get it to a point where I feel comfortable releasing it to my site, adding and changing stuff to my own liking. Have you ran into any issues with having the original file names saved? Definitely a situation where you'd want to escape the name just for safety. Mainly I was wondering if you chose hashed file names for a compatibility/security reason or out of design choice. Have you considered having a "instances" section in the readme.md , able to show public instances running this software? (If people make a pull request to have their website/instance added anyway) - just a quick thought/question , I've seen it done with LibreY and I liked the concept personally. What's your preferred method of contact if you don't mind? I'd enjoy discussing certain ideas/questions as they come up in a non public space, if you're up for it. Twitter, Discord, Whatsapp? |
For the hashing it is there to upload the same file more than once because I am generating a new file id for each upload. I am might look for a better method to handle this. For other contact channels u can try me on Discord fariscode. |
That makes sense. I'm thinking of having the file saved as a hashed version, but saving the filename in plaintext in the database to show / download as. I also came up with this but it doesn't seem ideal for me, just functional
atm, I'm looking into just having hash_id as the file name on disk, as that would not have duplicate files (for the same user) to exist and allow file_name to be the actual file name without the issue you brought up |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
So, I've set SMTP settings for gmail,
No errors at all, so I made a modification in Mailer.php
Adding
error_log($th->getMessage());
aftercatch (Exception $th) {
insendMessage
"PHP message: SMTP Error: Could not authenticate"
-> weird.This issue is on my end, not the codes end but I want to point out:
This was all while reportabuse.php is showing
Your report has been submitted successfully
So, log errors in some form + why not display if there was "an internal server error" that prevented the email from sending?
There's no errors if smtp is completely disabled either, so its something to think about
Apparently the issue I was having with authentication is due to this, switching to something like this worked just fine. Sorry for jumping
Also there was an issue I fixed here where the "Add Page"(manage pages) button was not functional due to there being no
element set(even though was set)Why don't any default 'translations' exist for about/privacy/terms?
It would be kinda nice(but unnecessary ultimately) to be able to add 'allowed' file extensions beyond editing
vendor/farisc0de/phpfileuploading/src/filter.json
I know of the functionality inside /src/Upload.php but I haven't narrowed it down to find the exact piece yet
The text was updated successfully, but these errors were encountered: