Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support esm and commonjs #128

Closed
wants to merge 4 commits into from
Closed

chore: support esm and commonjs #128

wants to merge 4 commits into from

Conversation

tqma113
Copy link
Collaborator

@tqma113 tqma113 commented Nov 17, 2021

  • chore: support esm and commonjs
  • chore(farrow): update esbuild

@Lucifier129
Copy link
Collaborator

The problems with ESM support of farrow are not only related to farrow itself, it's also related to the tools around farrow.

farrow emits esm files even now, but disable them in package.json intentionally to avoid the weird problems we met when integrating with other tools.

The benefit of farrow is not about ESM, it's about type-safe. It means farrow should always be compiled instead of imported directly in ESM runtime.

So in my opinion, keeping current status and waiting for the community to move on will be a better way.

@Lucifier129
Copy link
Collaborator

Anyway, thx your effort in ESM support, they will bring more value in the future:-)

@tqma113 tqma113 closed this Nov 19, 2021
@tqma113
Copy link
Collaborator Author

tqma113 commented Nov 26, 2021

vitejs/vite#5839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants