Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Remove mention of Celery in the project generators #12742

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

david-caro
Copy link
Contributor

@david-caro david-caro commented Nov 1, 2024

In full-stack-fastapi-template!694 celery was removed from the template project, it makes no sense anymore mentioning in the docs that is an example on how to use celery.

@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Nov 1, 2024
@david-caro
Copy link
Contributor Author

Being a simple removal of text, I bundled all the pages together, but if it's easier to review them one-by-one let me know and I'll split the change.

In fastapi/full-stack-fastapi-template#694
celery was removed from the template project, it makes no sense
anymore mentioning in the docs that is an example on how to use
celery.

Signed-off-by: David Caro <me@dcaro.es>
@alejsdev alejsdev changed the title 🌐 Remove mention of celery being in the project generators 📝 Remove mention of celery being in the project generators Nov 1, 2024
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - thanks for being so thorough through all the languages! In a case like this, it's definitely fine to keep all the changes in the same PR, as they're highly related.

I'll pass this on internally to Tiangolo for a final review 🙏

@alejsdev alejsdev changed the title 📝 Remove mention of celery being in the project generators 📝 Remove mention of Celery being in the project generators Nov 9, 2024
@alejsdev alejsdev changed the title 📝 Remove mention of Celery being in the project generators 📝 Remove mention of Celery in the project generators Nov 9, 2024
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense, thanks @david-caro! 🍰 ☕

And thanks for the reviews @svlandeg and @alejsdev 🙇

@tiangolo tiangolo merged commit bfaf4c3 into fastapi:master Nov 10, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants