-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Remove mention of Celery in the project generators #12742
📝 Remove mention of Celery in the project generators #12742
Conversation
Being a simple removal of text, I bundled all the pages together, but if it's easier to review them one-by-one let me know and I'll split the change. |
In fastapi/full-stack-fastapi-template#694 celery was removed from the template project, it makes no sense anymore mentioning in the docs that is an example on how to use celery. Signed-off-by: David Caro <me@dcaro.es>
dc46d1a
to
a3a6996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me - thanks for being so thorough through all the languages! In a case like this, it's definitely fine to keep all the changes in the same PR, as they're highly related.
I'll pass this on internally to Tiangolo for a final review 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, makes sense, thanks @david-caro! 🍰 ☕
In full-stack-fastapi-template!694 celery was removed from the template project, it makes no sense anymore mentioning in the docs that is an example on how to use celery.