Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing unpack_sequence from our list of benchmarks #35

Open
Fidget-Spinner opened this issue Mar 30, 2024 · 2 comments
Open

Comments

@Fidget-Spinner
Copy link

It's a microbenchmark and skews numbers unnecessarily.

Here's the code https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_unpack_sequence/run_benchmark.py

Here's an example benchmark run https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240330-3.13.0a5%2B-790b1f8-JIT/bm-20240330-pythonperf2-x86_64-brandtbucher-justin_align-3.13.0a5%2B-790b1f8-vs-base.md . Unpack_sequence is the clear outlier here.

@gvanrossum
Copy link

Agreed, we've been complaining about this benchmark long enough.

@mdboom
Copy link
Contributor

mdboom commented May 3, 2024

Yes, I agree. If we want to do this, we should probably file a PR against pyperformance and get at least one non-Faster CPython reviewer to approve it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants