Use let-if chain in "Log in with github" bit when rustfmt supports them

[Dygear]

It's no so much "wrong" as it could be updated I think -- This moves away from ...

https://fasterthanli.me/series/updating-fasterthanli-me-for-2022/part-6#position=59.3

Here's what it is:

        for item in patreon_response.data {
            if let Item::Member(member) = item {
                if let Some(full_name) = member.attributes.full_name.as_deref() {
                    if let Some(entitled) = member.rel("currently_entitled_tiers") {
                        for item_ref in entitled.data.iter() {
                            let ItemRef::Tier(tier_id) = item_ref;
                            if let Some(tier) = tiers_per_id.get(&tier_id.id) {
                                if let Some(title) = tier.attributes.title.as_deref() {
                                    if credited_tiers.contains(title) {
                                        credited_patrons.insert(full_name.to_string());
                                    } else {
                                        trace!("Tier {title} not credited");
                                    }
                                }
                            } else {
                                trace!("Tier for id {} not found", tier_id.id);
                            }
                        }
                    } else {
                        trace!("No currently_entitled_tiers for member: {}", full_name);
                    }
                }
            }
        }

With 1.65.0's if let this no longer needs to be a tower?

for item in patreon_response.data {
    if let Item::Member(member) = item else {
        continue;
    }

    if let Some(full_name) = member.attributes.full_name.as_deref() else {
        continue;
    }

    if let Some(entitled) = member.rel("currently_entitled_tiers") else {
        trace!("No currently_entitled_tiers for member: {}", full_name);
    }

    for item_ref in entitled.data.iter() {
        let ItemRef::Tier(tier_id) = item_ref;

        if let Some(tier) = tiers_per_id.get(&tier_id.id) else {
            trace!("Tier for id {} not found", tier_id.id);
        }

        if let Some(title) = tier.attributes.title.as_deref() else {
            continue;
        }

        if credited_tiers.contains(title) {
            credited_patrons.insert(full_name.to_string());
        } else {
            trace!("Tier {title} not credited");
        }
    }
}

Not sure if that's actually better or just different and I'm like "Oh I know a thing. Maybe I should use the thing."

[fasterthanlime]

No I agree, this would be a fantastic place for it. I think I'll wait until rustfmt is able to format let else properly until I do that though!

[fasterthanlime]

I regret to inform you that:

(lol @ result 2 being me complaining about it)

Also rust-lang/rustfmt#4914 is still open

I'm gonna go ahead and free myself from this issue tbqh.