Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #25

Closed
2 tasks done
kibertoad opened this issue Nov 28, 2021 · 4 comments
Closed
2 tasks done

Improve test coverage #25

kibertoad opened this issue Nov 28, 2021 · 4 comments

Comments

@kibertoad
Copy link
Member

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

We have around 50% code coverage.
We can do better.

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 4, 2021

We have now better coverage.

test coverage in master:

Statements   : 65.55% ( 940/1434 )
Branches     : 54.82% ( 506/923 )
Functions    : 71.9% ( 87/121 )
Lines        : 64.87% ( 857/1321 )

Should we increase the hard coded limits?

Curently:

    "lines": 51,
    "statements": 51,
    "functions": 49,
    "branches": 43

or maybe we wait till we merge #50 , which results that our test coverage will increase drastically
test coverage in replace-encodings branch

Statements   : 93.53% ( 810/866 )
Branches     : 86.8% ( 454/523 )
Functions    : 95.45% ( 63/66 )
Lines        : 96.41% ( 727/754 )

@kibertoad
Copy link
Member Author

kibertoad commented Dec 4, 2021

We should!
and yes, let's do it after the merge

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 4, 2021

Yeah.

=============================== Coverage summary ===============================
Statements   : 95.52% ( 812/850 )
Branches     : 90.34% ( 449/497 )
Functions    : 95.45% ( 63/66 )
Lines        : 97.07% ( 731/753 )
================================================================================

@gurgunday
Copy link
Member

Alright, just closing this to prevent duplicates

And I chose this one because the coverage was improved technically, as the title describes :D

Now we go for 100% 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants