feat: support Accept-Encoding token x-gzip as an alias for gzip
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
To ensure that this plugin is following the spec guidance, this PR aims to :
x-gzipas an alias forgzip(feat)Accept-Encodingtokenx-gzipis interpreted as an alias ofgzip(test)ref.: HTTP/1.1 RFC 7230 section 4.2.3 and IANA maintained Table of Content Encodings
Note: server-side we do not need to support this alias inside
encodings,requestEncodingsandforceRequestEncodingoptions (we should push good practices adoption) but client-side we should support it even though it's considered deprecated.Checklist
npm run testandnpm run benchmarkand/or benchmarksare includedand the Code of conduct