Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Functions for customType option #262

Merged
merged 2 commits into from
May 14, 2023
Merged

Support Functions for customType option #262

merged 2 commits into from
May 14, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented May 11, 2023

Well. Why not?

Checklist

Eomm
Eomm reviewed May 13, 2023
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just suggested a clearer var name 👍🏼

README.md Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@Eomm Eomm mentioned this pull request May 13, 2023
Merged
mcollina
mcollina approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak @Eomm
Apply suggestions from code review
bff1f9a 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@Uzlopak
Copy link
Contributor Author

Uzlopak commented May 13, 2023

@Eomm
PTAL

@Eomm Eomm merged commit 0c74f85 into master May 14, 2023
@Eomm Eomm deleted the support-functions-for-customTypes-option branch May 14, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

@jsumners jsumners Awaiting requested review from jsumners

@climba03003 climba03003 Awaiting requested review from climba03003

@darkgl0w darkgl0w Awaiting requested review from darkgl0w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @Eomm