Add type definitions for parseOptions in FastifyCookieOptions

[MoSheikh]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

Currently, parseOptions is not defined under FastifyCookieOptions. I was hoping to change the FastifyCookieOptions interface to the following:

// plugin.d.ts

export interface FastifyCookieOptions {
  secret?: string | string[];
  parseOptions?: CookieSerializeOptions;
}

And add the following test:

// test/plugin.d.ts

const appWithParserOptions = fastify();

const parseOptions: fastifyCookieStar.CookieSerializeOptions = {
  domain: "example.com",
  encode: (value: string) => value,
  expires: new Date(),
  httpOnly: true,
  maxAge: 3600,
  path: "/",
  sameSite: "lax",
  secure: true,
  signed: true,
};
expectType<fastifyCookieStar.CookieSerializeOptions>(parseOptions);

appWithParserOptions.register(cookie, {
  secret: "testsecret",
  parseOptions,
});
appWithParserOptions.after(() => {
  server.get("/", (request, reply) => {
    const { valid, renew, value } = reply.unsignCookie(request.cookies.test);

    expectType<boolean>(valid);
    expectType<boolean>(renew);
    expectType<string | null>(value);
  });
});

Motivation

No response

Example

No response

[mcollina]

Thanks! Would you like to send a Pull Request to address this issue?

[MoSheikh]

Sure! I did try pushing a branch through but it gave me a Permission Denied error - would I need to be added as a contributer?

[mcollina]

You'll need to fork the project first, take a look at https://www.google.com/amp/s/www.freecodecamp.org/news/how-to-make-your-first-pull-request-on-github-3/amp/

[MoSheikh]

@mcollina Oh right - thank you! Here's the PR.