-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing priority option. #274
Comments
The type was there but I couldn’t find the real code, and assumed it didn’t exist, I’ll take another look |
Seems like that option didn’t really exist for a while now I don’t see Priority defined in RFC 6265 either Do you really need it? |
Is it? In the 9.1.0, the cookie I created could use priority High and the cookie is actually on top of the cookie list. In the 9.3.0, the cookie is always Medium in the middle of the list. I'm not sure if it 100% neccessary, but it's my authentication cookie. If I have an option to make its priority as high as I could I would do it. I'm not acknowledged about RFC requirements, but Priority is an actual mechanism that is used by current browsers. And there is no mention or indication that they were deprecated, I can't find them anywhere (!). So I don't see why it was removed when it still being implemented by the browsers. |
I vote on keeping the fork and adding it here |
I think we should keep the fork at this point. We have been adding it back every now and then because of the slow responsiveness of |
Created PR #275 |
Prerequisites
Fastify version
4.25.2
Plugin version
9.3.0
Node.js version
20.5.1
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
Sonoma
Description
The priority options was removed in 9.2.0, and the cookies are defaulted to priority Medium now.
9e4652f
Steps to Reproduce
The text was updated successfully, but these errors were encountered: