fix(types): stricter types for unsigned cookies #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
This PR narrows the return type of
unsign
to better reflect the Signer logic. Specifically, that if unsigning fails therenew
property will befalse
andvalue
will benull
, but if it succeedsrenew
can beboolean
, butvalue
can only be astring
, nevernull
.This is consistent with the logic in the default Signer, but it does mean that custom Signers have to use the same high-level logic.