Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes all properties/params required, required: [] option is ignored #159

Closed
2 tasks done
waveiron opened this issue Jul 4, 2024 · 3 comments
Closed
2 tasks done

Comments

@waveiron
Copy link

waveiron commented Jul 4, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

^4.26.2

Plugin version

^4.0.0

Node.js version

20.14.0

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

14.5

Description

For example, in this schema, only "name" is required:

export const args = {
  required: ['name'],
  type: 'object',
  properties: {
    paths: {
      type: ['string', 'null'],
    },
    name: { type: 'string' },
    age: { type: 'number' },
  },
};

but ui requires all properties:

CleanShot 2024-07-04 at 15 35 50@2x

Link to code that reproduces the bug

No response

Expected Behavior

No response

@mcollina
Copy link
Member

mcollina commented Jul 6, 2024

Thanks for reporting!

Can you provide steps to reproduce? We often need a reproducible example, e.g. some code that allows someone else to recreate your problem by just copying and pasting it. If it involves more than a couple of different file, create a new repository on GitHub and add a link to that.

@sceccotti89
Copy link
Contributor

I don't think this is an issue, because those are path parameters and they are required by definition

@Uzlopak
Copy link
Collaborator

Uzlopak commented Sep 16, 2024

Closing it as there was no mvce provider.

@Uzlopak Uzlopak closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants