Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Cleanup npm package #108

Closed
wants to merge 1 commit into from
Closed

[Chore] Cleanup npm package #108

wants to merge 1 commit into from

Conversation

yhnavein
Copy link

chore: remove unnecessary files from the npm package

This PR does not contain any change to the logic or the implementation. It is only reducing size of npm package by excluding files that are not necessary for a standard usage of this library.

Before: 6KB gzipped (22 KB and 21 files unpacked)
After: 4KB gzipped (11 KB and 5 files unpacked)

It may be a small change but for 7M downloads weekly this is suddenly ~56 GB less of data transfer per month.

New tarball contents

Tarball Contents
----------------
1.1kB LICENSE
4.2kB README.md
4.0kB index.js
1.1kB package.json
932B types/index.d.ts

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 17, 2024

@jsumners PTAL

@Eomm
Copy link
Member

Eomm commented Aug 17, 2024

Thank you for your interest in this topic. Please see the discussion in fastify/skeleton#42 (comment) for my reasoning against such a change.

@mcollina
Copy link
Member

Here is a video explanation too: https://youtu.be/D18jlN2JNE0?si=iDKR6g9JZh4iLUk3

@yhnavein yhnavein closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants