Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:GoRename error - vim-go: gorename: -to "0": not a valid identifier #627

Closed
nerdyworm opened this issue Nov 26, 2015 · 7 comments
Closed

Comments

@nerdyworm
Copy link

This seems to be the start of the problems for me: #577

If there is any additional information I can provide to help fix this please let me know. Or if you can point me in the right direction then even better :D

@fatih
Copy link
Owner

fatih commented Nov 29, 2015

Hi @nerdyworm. I don't think that you're given commit id is the root cause here.

Can you please provide more info about what's going on here? Please provide a reproducible test case.

@nerdyworm
Copy link
Author

Typing :GoRename with my cursor on an identifier it spits out the error message.
Typing :GoRename newName also spits out the same error.

If I run the command definition of the previous version everything seems to function correctly
command! -nargs=? GoRename call go#rename#Rename(<f-args>)

however when I use the most recent version, the error occurs.
command! -nargs=? GoRename call go#rename#Rename(<bang>0,<f-args>)

@fatih
Copy link
Owner

fatih commented Nov 29, 2015

This is really weird. I'm using the latest master and it works fine. Are you sure you updated all your files?

@nerdyworm
Copy link
Author

I'm certain that all the plugin's files are updated correctly.

Here's what I'm going to do. I'm going to close this issue and just assume it's my local area that is broken and not the wonderful plugin :) If I find something I'll add another comment or send a PR.

If other people have this same issue they should chime in. Until then we can assume it's my vim issue, which is extremely likely.

Thanks. I really appreciate all your hard work on this project.

@fatih
Copy link
Owner

fatih commented Nov 29, 2015

@nerdyworm sure :) Btw, I'm really open to resolve issues. But If I can't reproduce it, there is not much I can do. What you can do is compare the files, try to provide more cases and co. Thanks for using vim-go :)

@ernesto-jimenez
Copy link

@nerdyworm did you get this fixed? I've got the same problem :)

@nerdyworm
Copy link
Author

@ernesto-jimenez I just shoved the following into my vimrc

map ,rn :call go#rename#Rename()<cr>

(shrug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants