Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-3754] Event Feeds: Document pageSize limit #191

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[DOCS-3754] Event Feeds: Document pageSize limit #191

merged 1 commit into from
Nov 19, 2024

Conversation

jrodewig
Copy link
Contributor

Description

Documents accepted range for pageSize in FeedOptions

Motivation and context

Keeps docs updated with changes in https://github.com/fauna/core/pull/12010.

How was the change tested?

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jrodewig jrodewig requested a review from findgriffin November 18, 2024 20:01
@jrodewig jrodewig changed the title [DOCS-3754] Event Feeds: Document page_size limit [DOCS-3754] Event Feeds: Document pageSize limit Nov 18, 2024
erickpintor
erickpintor approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it.

@jrodewig jrodewig merged commit 73ebcb1 into main Nov 19, 2024
1 check passed
@jrodewig jrodewig deleted the page-size-limit branch November 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickpintor erickpintor erickpintor approved these changes

@findgriffin findgriffin Awaiting requested review from findgriffin

@pnwpedro pnwpedro Awaiting requested review from pnwpedro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrodewig @erickpintor