Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab length doesn't seem to work #8

Open
verheyenkoen opened this issue Jun 30, 2015 · 4 comments
Open

Tab length doesn't seem to work #8

verheyenkoen opened this issue Jun 30, 2015 · 4 comments

Comments

@verheyenkoen
Copy link

I have my general tab length set to 4, and for atom-drupal I want to use 2 (as specified in the Drupal coding standards). However, the files with extensions specified in File Types PHPsetting don't seem to have this setting applied.

@robballou
Copy link
Contributor

atom-drupal and language-php don't set the tab settings. It's probably worth a discussion on if that should be set or not at the atom-drupal level.

In the meantime, you can also set it via language-specific settings: https://atom.io/docs/latest/using-atom-basic-customization

I think atom-drupal could easily add this to help people write per the Drupal coding spec. I'm curious what others think. Here's an example of Python settings which sets it to 4 spaces (Python's spec): https://github.com/atom/language-python/blob/master/settings/language-python.cson

@verheyenkoen
Copy link
Author

Ok, I guess I was already referring to language-specific settings (which appear under the package settings). I thought that was a package specific feature. So the bug should be in Atom core.

@robballou
Copy link
Contributor

I don't think it's a bug in core unless adding the settings don't work. Looking closer at atom-drupal we may need to do slightly more than just including a settings file to make a change but it's probably still possible.

I think if you add this to your config, you will get what you want for language-php. Unless you want it different for Drupal v. general PHP...

'.text.html.php':
  'editor':
    'tabLength': 2

Hope that helps!

@verheyenkoen
Copy link
Author

Can't get it to work like this. It seems to work for the first 2 "tabs" on a line but no further. Also the tab indicator lines don't show correctly. Will see if I find a bug report on the grammar feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants