Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticking the "Remove Empty Groups" tickbox stops empty groups being created anywhere #28

Closed
eAi opened this issue May 18, 2020 · 3 comments
Labels

Comments

@eAi
Copy link

eAi commented May 18, 2020

This may be by design, but certainly confused me: Having the Remove Empty Groups tick box prevents groups being created manually in the Addressables Groups window - as these are empty by default.

Steps to reproduce:

  • Tick the Remove Empty Groups tickbox in the import settings file
  • Open the Addressables Groups window
  • Right click and select Create New Group > Packed Assets
  • Notice that nothing happens

Ideally, this tickbox wouldn't do anything to manually created groups - just those that had been created by the import process. This would probably require tracking these groups in some way. Could a new class be created that derives from AddressableAssetGroup that is used to mark groups that are 'managed' by the importer? Alternatively, a big warning on this tickbox might help - it does seem quite dangerous!

@favoyang
Copy link
Owner

favoyang commented May 18, 2020

You made the point. But it's not ideal to implement such a thing without a visible way to show users whether a group is managed. What if a user creates a managed group, then delete the rule, the group is managed or not?

Alternatively, I propose to retire the feature and replaced it with a [clean empty groups] button. It will also make this PR #24 gone.

@eAi
Copy link
Author

eAi commented May 18, 2020

I'm feeling that on balance removing this feature is probably sensible - I don't think there's any real harm caused by empty groups - it's just messy - and there seems to be some definite harm by having the option there. If the empty groups bother you, you can just delete them - they're easy to identify as they don't have the expand arrow next to them.

@github-actions
Copy link

🎉 This issue has been resolved in version 0.7.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants