Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: documentation #63

Open
mkroman opened this issue Feb 11, 2019 · 3 comments
Open

Feature request: documentation #63

mkroman opened this issue Feb 11, 2019 · 3 comments

Comments

@mkroman
Copy link

mkroman commented Feb 11, 2019

This gem desperately lacks documentation of the code. Navigating the code trying to figure out where something is instantiated and used when using it with my own code that's using EventMachine takes a lot of effort. Documenting the code would make this much easier.

I'm creating this feature request to track this effort.

@jcoglan
Copy link
Collaborator

jcoglan commented Feb 11, 2019

Could you be a little more specific about ways in which the documentation is not serving your needs, or what questions it's not answering?

@mkroman
Copy link
Author

mkroman commented Feb 17, 2019

Sorry for the late reply and the lack of clarification.

I meant to say that the code of the gem lacks documentation. I'm working with some code that tries to clean up servers and gracefully close connections, and it's been difficult navigating this library's code.

@jcoglan
Copy link
Collaborator

jcoglan commented May 28, 2019

So for a variety of reasons I tend not to do API documentation -- largely because the library's users won't actually touch most of the methods directly, and because it doesn't do a great job of telling them how to use the library.

As regards your issue, one reason I'd struggle to do this is that I don't know what sorts of questions you have or what about the codebase is confusing -- I'm biased by my familiarity with it. It's possible that other forms of docs would be better for your use, e.g. in the style of the architecture docs here:

https://faye.jcoglan.com/architecture.html

If you give me some of the specific questions you have, I can probably answer them and this would provide useful input for seeing what extra docs we should have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants