Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS check does not properly work for DC 2019 #473

Closed
TuemmlerKelch opened this issue Nov 28, 2023 · 2 comments · Fixed by #474
Closed

OS check does not properly work for DC 2019 #473

TuemmlerKelch opened this issue Nov 28, 2023 · 2 comments · Fixed by #474
Assignees
@qngngyn
Labels
bug Something isn't working minor Incremental updates and enhancements for improved functionality without major changes.
Milestone
5.7.1

Comments

@TuemmlerKelch
Copy link
Collaborator

Please check the logic issue here.
Screenshot taken from my Server 2019 DC
image
@TuemmlerKelch TuemmlerKelch added bug Something isn't working minor Incremental updates and enhancements for improved functionality without major changes. labels Nov 28, 2023
@TuemmlerKelch TuemmlerKelch added this to the 5.7.1 milestone Nov 28, 2023
@qngngyn
Copy link
Collaborator

qngngyn commented Nov 28, 2023 •
edited
Loading

@TuemmlerKelch Can you please run

  • (Get-CimInstance -Class Win32_ComputerSystem).DomainRole

and give me the result?

@qngngyn qngngyn mentioned this issue Nov 28, 2023
Merged
@qngngyn
Copy link
Collaborator

qngngyn commented Nov 28, 2023

Bug has been identified:

  • Check was asking for int values (4 or 5 for DCs)
  • Get-Domainrole function doesn't return int values, but returns readable string instead

@qngngyn qngngyn linked a pull request Nov 29, 2023 that will close this issue
Fix Bug: Check now correct #474
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qngngyn qngngyn

Labels
bug Something isn't working minor Incremental updates and enhancements for improved functionality without major changes.
Projects
None yet
Milestone
5.7.1
Development

Successfully merging a pull request may close this issue.

Fix Bug: Check now correct fbprogmbh/Audit-Test-Automation
2 participants
@TuemmlerKelch @qngngyn