From bd6b44be1c0fdc2c93823817214915f2fe2a8bec Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Tue, 1 Mar 2022 17:02:07 -0800 Subject: [PATCH] fix: Update github workflow to prevent redis from overlapping ports. (#2350) * Update redis port Signed-off-by: Kevin Zhang * Add comment detailing why 12345 is port selected Signed-off-by: Kevin Zhang * Keep redis at 6379 for now until we can test against new github workflow Signed-off-by: Kevin Zhang --- .github/workflows/pr_integration_tests.yml | 5 +++++ .../tests/integration/feature_repos/repo_configuration.py | 1 + 2 files changed, 6 insertions(+) diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml index 000f9e9728..1a914473c1 100644 --- a/.github/workflows/pr_integration_tests.yml +++ b/.github/workflows/pr_integration_tests.yml @@ -102,6 +102,11 @@ jobs: # code from the PR. ref: refs/pull/${{ github.event.pull_request.number }}/merge submodules: recursive + - name: Start Redis + uses: supercharge/redis-github-action@1.4.0 + with: + redis-version: ${{ matrix.redis-version }} + redis-port: 12345 - name: Setup Python uses: actions/setup-python@v2 id: setup-python diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py index 7169e41e8e..c9de56b76a 100644 --- a/sdk/python/tests/integration/feature_repos/repo_configuration.py +++ b/sdk/python/tests/integration/feature_repos/repo_configuration.py @@ -46,6 +46,7 @@ ) DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"} +# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate. REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"} REDIS_CLUSTER_CONFIG = { "type": "redis",