From dedc1645ef1f38aa9b50a0cf55e4bc23ec60d5ad Mon Sep 17 00:00:00 2001 From: Tommy Hughes IV Date: Wed, 1 May 2024 10:35:09 -0500 Subject: [PATCH] fix: Helm chart `feast-feature-server`, improve Service template name (#4161) fix: feast-feature-server helm chart's Service template Signed-off-by: Tommy Hughes --- examples/python-helm-demo/README.md | 4 ++-- infra/charts/feast-feature-server/templates/service.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/python-helm-demo/README.md b/examples/python-helm-demo/README.md index 44cd4799d5..90469e746d 100644 --- a/examples/python-helm-demo/README.md +++ b/examples/python-helm-demo/README.md @@ -72,11 +72,11 @@ We use the Feast CLI to register and materialize features, and then retrieving v 3. `helm install feast-release ../../../infra/charts/feast-feature-server --set image.tag=dev --set feature_store_yaml_base64=$(base64 feature_store.yaml)` 5. (Optional): check logs of the server to make sure it’s working ```bash - kubectl logs svc/feast-feature-server + kubectl logs svc/feast-release-feast-feature-server ``` 6. Port forward to expose the grpc endpoint: ```bash - kubectl port-forward svc/feast-feature-server 6566:80 + kubectl port-forward svc/feast-release-feast-feature-server 6566:80 ``` 7. Run test fetches for online features:8. - First: change back the Redis connection string to allow localhost connections to Redis diff --git a/infra/charts/feast-feature-server/templates/service.yaml b/infra/charts/feast-feature-server/templates/service.yaml index d6914828e4..db0ac8b10b 100644 --- a/infra/charts/feast-feature-server/templates/service.yaml +++ b/infra/charts/feast-feature-server/templates/service.yaml @@ -1,7 +1,7 @@ apiVersion: v1 kind: Service metadata: - name: {{ include "feast-feature-server.name" . }} + name: {{ include "feast-feature-server.fullname" . }} labels: {{- include "feast-feature-server.labels" . | nindent 4 }} spec: