Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default dump format should be changed for Python SDK #133

Closed
woop opened this issue Feb 16, 2019 · 1 comment · Fixed by #143
Closed

Default dump format should be changed for Python SDK #133

woop opened this issue Feb 16, 2019 · 1 comment · Fixed by #143
Labels
good first issue Good for newcomers

Comments

@woop
Copy link
Member

woop commented Feb 16, 2019

Expected Behavior

When using the Python SDK to dump an "Importer" to a YAML file, the type should be "file.csv"

Current Behavior

Using the dump method results in the importer's type being saved as "file", which fails validation when using the YAML file for importing from the CLI.

Steps to reproduce

Follow the current Quickstart here

Dump the importer after it is defined.

importer.dump('out.yaml')

Specifications

  • Version: 0.0.1
  • Platform: Ubuntu 18.04
  • Subsystem:

Possible Solution

This default probably needs to be changed:
https://github.com/gojek/feast/blob/master/sdk/python/feast/sdk/importer.py#L121
@woop woop added the good first issue Good for newcomers label Feb 16, 2019
@woop
Copy link
Member Author

woop commented Feb 16, 2019

Not sure about intended behavior, which is why I created the issue.

@pradithya pradithya mentioned this issue Feb 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix import spec created from Importer.from_csv pradithya/feast
1 participant
@woop