Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast apply and Google Datastore dependency #1485

Closed
SaschaHeyer opened this issue Apr 21, 2021 · 3 comments
Closed

feast apply and Google Datastore dependency #1485

SaschaHeyer opened this issue Apr 21, 2021 · 3 comments
Labels
kind/bug wontfix This will not be worked on

Comments

@SaschaHeyer
Copy link

Expected Behavior

Running feast apply works without errors

Current Behavior

Running feast apply runns into an error if client library is not installed https://cloud.google.com/datastore/docs/reference/libraries#client-libraries-install-python

cannot import name 'datastore' from 'google.cloud'

We should mention this dependency in the documentation.

Steps to reproduce

  1. Run feast apply in an environment where the datastore client library is not installed

Specifications

  • Version: 0.10.0
  • Platform: Mac
  • Subsystem:

Possible Solution

Install it with pip install --upgrade google-cloud-datastore

@woop
Copy link
Member

woop commented Apr 21, 2021

Good catch. Thanks @SaschaHeyer!

@woop woop added the kind/bug label Apr 21, 2021
@diogommartins
Copy link
Contributor

Relates to #1560

@stale
Copy link

stale bot commented Sep 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 14, 2021
@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants