Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache non file-based registries for python feature server #3328

Closed
sfc-gh-madkins opened this issue Nov 2, 2022 · 2 comments · Fixed by #3395
Closed

Cache non file-based registries for python feature server #3328

sfc-gh-madkins opened this issue Nov 2, 2022 · 2 comments · Fixed by #3395
Assignees
Labels
kind/feature New feature or request priority/p1

Comments

@sfc-gh-madkins
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

A considerable amount of latency occurs when retrieving data from registry when calling get_online_features()

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@sfc-gh-madkins sfc-gh-madkins added kind/feature New feature or request priority/p1 labels Nov 2, 2022
@sfc-gh-madkins sfc-gh-madkins changed the title Cache non file-based registries for python feature sserver Cache non file-based registries for python feature server Nov 2, 2022
@jfli-thu
Copy link

jfli-thu commented Nov 3, 2022

Maybe we can support customize registry in feature_store.yaml firstly so that we can use customized registry cache implementation?

@jfli-thu
Copy link

jfli-thu commented Nov 3, 2022

it seems the amount of latency using sql registry may also relate to the unnecessary feast_metadata update when get or list metadata .

Should that init func only used by apply_objects? @adchia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants