fix: Updating the batch field so that you can query create and event date. #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojavierarceo
force-pushed
the
query-created-date
branch
from
902ae5b
to
bfb88c5
Compare
franciscojavierarceo
changed the title
franciscojavierarceo
changed the title
franciscojavierarceo
changed the title
franciscojavierarceo
force-pushed
the
query-created-date
branch
from
c11fcaa
to
ba2eca4
Compare
franciscojavierarceo
force-pushed
the
query-created-date
branch
from
c42cc51
to
fcb821a
Compare
franciscojavierarceo
changed the title
adchia
reviewed
Jan 3, 2023
| @@ -599,6 +599,11 @@ def _normalize_timestamp( | |||
| created_timestamp_column_type = df_to_join_types[created_timestamp_column] | |||
|
|
|||
| if not hasattr(timestamp_field_type, "tz") or timestamp_field_type.tz != pytz.UTC: | |||
| # if you are querying for the event timestamp field, we have to deduplicate | |||
There was a problem hiding this comment.
not fully sure i understand what these duplicate columns are coming from? Can you leave more comments on why?
There was a problem hiding this comment.
yeah i'll update the PR but basically querying for created in get_online_features duplicates the created_timestamp_column. So I could go deeper and try to fix the duplication but I needed a quick fix on my side and it works correctly for us.
There was a problem hiding this comment.
@adchia updated the comment 👍
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, franciscojavierarceo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix: Add assertion condition when value is 0 Signed-off-by: zlatan.el <zlatan.el@kakaomobility.com> * chore: Add comment about zero value validation Signed-off-by: zlatan.el <zlatan.el@kakaomobility.com> * chore: Modifiy the comment Signed-off-by: zlatan.el <zlatan.el@kakaomobility.com> * chore: Add the comment Signed-off-by: zlatan.el <zlatan.el@kakaomobility.com> Signed-off-by: zlatan.el <zlatan.el@kakaomobility.com> Co-authored-by: zlatan.el <zlatan.el@kakaomobility.com> Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
…of a model you can just add it in the get_online_features feature argument Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
franciscojavierarceo
force-pushed
the
query-created-date
branch
from
df1736f
to
9eba3ea
Compare
|
sorry @adchia looks like I had to redo the sign off will need another stamp |
|
/lgtm |
kevjumba
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [0.29.0](v0.28.0...v0.29.0) (2023-01-31) ### Bug Fixes * Add check for bool type in addition to sample ([#3452](#3452)) ([1c7c491](1c7c491)) * Buggy SQL for postgres source ([#3424](#3424)) ([1ea100e](1ea100e)) * Ensure no duplicates in `fv.schema` ([#3460](#3460)) ([08ffa8d](08ffa8d)) * Fix delete sfv twice issue ([#3466](#3466)) ([dfd5eae](dfd5eae)) * Stream feature view UI shows transformation issue ([#3464](#3464)) ([1ef5137](1ef5137)) * Update registry.refresh to have a default arg ([#3450](#3450)) ([2f7c4ed](2f7c4ed)) * Updating the batch field so that you can query create and event date. ([#3411](#3411)) ([01ab462](01ab462)), closes [#3401](#3401) ### Features * Add data source search ([#3449](#3449)) ([fbbb293](fbbb293)) * Adding list_validation_references for default and sql registry ([#3436](#3436)) ([21dd253](21dd253)) * Make UI accessible behind proxy ([#3428](#3428)) ([753d8db](753d8db))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows users to call
get_online_featuresorget_historical_featureswith thecreatedorevent_timestampfields in thefeaturesfunction call and return the proper data.Which issue(s) this PR fixes:
Fixes # #3412