Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_snowflake for generation of offline features does nothing if the table exists in Snowflake. #3447

Closed
sfc-gh-rsaxena opened this issue Jan 12, 2023 · 0 comments · Fixed by #3589
Labels
kind/feature New feature or request

Comments

@sfc-gh-rsaxena
Copy link

Is your feature request related to a problem? Please describe.
to_Snowflake fires CREATE TABLE IF NOT EXISTS to create a new table to store offline features. It does not overwrite or append into the existing table. It has its benefits, but could also be very misleading since it doesn’t throw any warning, messages or anything to inform the user that it didn’t write new records to the table.

fs.get_historical_features(features=feature_service, entity_df=customers).to_snowflake(table_name='historical_features')
Describe the solution you'd like
There should be a Warning message informing the user that the table with the same name exist and no action will be taken.

Describe alternatives you've considered
Couple of ways to make it work every time you need to get most recent data is to either programatically change the name and store in a new table each time or delete existing table and then recreate the table.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant