Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch retrieval fails to catch certain errors #364

Closed
zhilingc opened this issue Dec 13, 2019 · 0 comments
Closed

Batch retrieval fails to catch certain errors #364

zhilingc opened this issue Dec 13, 2019 · 0 comments

Comments

@zhilingc
Copy link
Collaborator

zhilingc commented Dec 13, 2019

Batch retrieval for BQ fails to catch the following errors:

  1. Loading entity dataset into BQ
  2. Allocating UUIDs for rows in the entity dataset
# BigQueryServingService.java

  public GetBatchFeaturesResponse getBatchFeatures(GetBatchFeaturesRequest getFeaturesRequest) {
    ....
    // here
    Table entityTable = loadEntities(getFeaturesRequest.getDatasetSource());
    ....
    // and here
    TableId entityTableWithUUIDs = generateUUIDs(entityTable);
    String entityTableName = generateFullTableName(entityTableWithUUIDs);
    ....
  }

As a result when retrieving using the python sdk the sdk polls forever, unbeknownst to the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant