Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for table_create_disposition in bigquery job for offline store #3763

Closed
nickozilla opened this issue Sep 12, 2023 · 0 comments · Fixed by #3762
Closed

Add support for table_create_disposition in bigquery job for offline store #3763

nickozilla opened this issue Sep 12, 2023 · 0 comments · Fixed by #3762
Labels
kind/feature New feature or request

Comments

@nickozilla
Copy link
Contributor

nickozilla commented Sep 12, 2023

Is your feature request related to a problem? Please describe.
The current configuration of the bigquery.LoadJobConfig() in the bigquery offline store leaves the create_disposition undefined, defaulting to "CREATE_IF_NEEDED", which requires the service account that is sending the data from the feast server into the offline store to be given the bigquery.tables.create. This is not ideal for our setup, as our tables will be created and managed by a different service separate to feast, and giving the SA this permission would create a risk of data exposure.

Describe the solution you'd like
A way to allow users to declare the type of create_disposition they'd want, defaulting to the existing behaviour if left unset.

Describe alternatives you've considered
Maintain a fork of feast with this modification made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant