Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two featureviews share the same name between stream feature views and regular feature views #3836

Closed
sutodi opened this issue Nov 14, 2023 · 4 comments

Comments

@sutodi
Copy link

sutodi commented Nov 14, 2023

I have a stream feature view running fine in 0.29. When upgrading to 0.34, getting error on doing feast apply
“feast.errors.ConflictingFeatureViewNames: The feature view name: job_stream refers to feature views of different types.”
Printing type in registry.py in function _check_conflicting_feature_view_names where error is coming.
“print(“feature view instance”, feature_view.proto_class, type(name_to_fv_protos.get(feature_view.name)))”
getting output:
feature view instance <class ‘feast.core.FeatureView_pb2.FeatureView’> <class ‘feast.core.StreamFeatureView_pb2.StreamFeatureView’>
I feel like this might be because of #3582

@sutodi
Copy link
Author

sutodi commented Nov 16, 2023

@loftiskg @achals @adchia

@redhatHameed
Copy link
Contributor

@shuchu just confirming if this issue still required any attention or can be closed based on you PR which merged already

@shuchu
Copy link
Collaborator

shuchu commented Feb 20, 2024

It was fixed and we are good to close it.:)

@redhatHameed
Copy link
Contributor

Thanks @shuchu for confirming.

@jeremyary @etirelli can you help to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants