Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing argument in error string in ValidateFeatureRowDoFn #401

Closed
zhilingc opened this issue Jan 3, 2020 · 0 comments · Fixed by #404
Closed

Missing argument in error string in ValidateFeatureRowDoFn #401

zhilingc opened this issue Jan 3, 2020 · 0 comments · Fixed by #404
Labels
good first issue Good for newcomers

Comments

@zhilingc
Copy link
Collaborator

zhilingc commented Jan 3, 2020

Too few arguments given for this error string in feast.ingestion.transform.fn.ValidateFeatureRowDoFn: line 66

 error =
              String.format(
                  "FeatureRow contains field '%s' which do not exists in FeatureSet '%s' version '%d'. Please check the FeatureRow data.",
                  field.getName(), featureSet.getReference());

This results in an exception being thrown instead when an incoming feature row has an additional field:

java.util.MissingFormatArgumentException: Format specifier '%d'
        java.util.Formatter.format(Formatter.java:2519)
        java.util.Formatter.format(Formatter.java:2455)
        java.lang.String.format(String.java:2940)
        feast.ingestion.transform.fn.ValidateFeatureRowDoFn.processElement(ValidateFeatureRowDoFn.java:66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant