[chore] Move Javadoc failures away from end-to-end test phase

[ches]

Moved from #407 (comment)

Currently the maven-javadoc-plugin is bound to the jar goal, so it triggers when end-to-end tests run mvn package.

An end-to-end test phase is a frustrating time to fail on malformatted Javadoc… (and generating them is a bit of a waste of time outside of release preparation). Perhaps we can do something like:

1. For tests, run mvn package with -Dmaven.javadoc.skip
2. Worry about Javadoc cleanup at release preparation time, automated in a release build

Or if you'd like for contributors to maintain error-free Javadoc proactively:

1. Run some type of Coding Standards check early in PR build steps, including invoking a goal from the Javadoc plugin
2. For tests, run mvn package with -Dmaven.javadoc.skip

Javadoc skip could be enabled by default in the root build, and disabled in a release profile.

[ches]

@woop prefers the latter direction per #407 (comment).

I can take a stab at updating Maven config to avoid Javadoc generation except in a release profile, and either defining a meta-goal like mvn check or lint to contain things like Javadoc and Spotless check (or just bind existing ones to an early lifecycle phase like validate, whatever works best, but I don't want to block people from compiling in day-to-day dev because of formatting compliance, that's failing too fast).

I'll probably need a pointer or help to actually make a Prow build step for that, but that should be a small matter when we get there.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.